GLOWS - Propagate bad-angle flags from L1B Histogram to L2 in GLOWS#2813
Open
laspsandoval wants to merge 4 commits intoIMAP-Science-Operations-Center:devfrom
Open
GLOWS - Propagate bad-angle flags from L1B Histogram to L2 in GLOWS#2813laspsandoval wants to merge 4 commits intoIMAP-Science-Operations-Center:devfrom
laspsandoval wants to merge 4 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
laspsandoval
changed the title
Co-authored-by: Tenzin Choedon <36522642+tech3371@users.noreply.github.com>
Co-authored-by: Tenzin Choedon <36522642+tech3371@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and propagation of the
histogram_flag_arrayin the GLOWS L2 data processing pipeline, ensuring that flags are correctly OR'd across all relevant L1B blocks per bin. It also updates and expands the test suite to verify this logic, including edge cases for empty datasets.Flag propagation logic:
__post_init__method inglows_l2_data.pyto computehistogram_flag_arrayby OR'ing all flag values across epochs and flag rows for each bin, per Section 12.3.4, ensuring a flag is set in L2 if it is set in any L1B block.Test suite improvements:
test_glows_l2_data.pyto include the correct shape and initialization forhistogram_flag_array, matching the updated logic. [1] [2]